Class SyntheticFuel is missing

l-emele commented 4 years ago

Description of the issue

Within the class fuels a subclass ~~ElectricFuel~~ SyntheticFuel is missing. This class should also have the subclasses Hydrogen, SyntheticMethane and SyntheticLiquidFuel (exact wording for discussion).

Along we need the following new technology classes PowerToLiquid, WaterElectrolysis and SteamRefoming.

Ideas of solution

To avoid merge conflicts work on this issue might be postponed until pull requests #105 and #130 are approved as these PRs heavily influence fuels.

Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every new entry in the ontology should have an annotation
[ ] classes should arise from concepts rather than from words
[ ] class or property names should follow the UpperCamelCase

l-emele commented 4 years ago

The PR #105 and #130 are merged so we could start with this issue.

Proposed definitions and structure:

Class: SyntheticFuel
  Definition: An synthetic fuel is a fuel produced from one or more portion(s) of matter using electric energy.
  SubClassesOf:
    has_origin value synthetic,
    has_disposition some Fuel

Class: SyntheticMethane
  Definition: "Synthetic methane is synthetic fuel produced from water and carbon dioxide using electric energy applying the power-to-gas technology."
  SubClassOf:
    SyntheticFuel,
    has_origin value synthetic,
    has_normal_state_of_matter value gaseous,
    has_disposition some Fuel

Class: SyntheticLiquidFuel
  Definition: "Synthetic liquid fuel is synthetic fuel produced from water and carbon dioxide using electric energy applying the power-to-liquid technology."
  SubClassOf:
    SyntheticFuel,
    has_origin value synthetic,
    has_normal_state_of_matter value liquid,
    has_disposition some Fuel

Hydrogen has currently the following class structure and definition

Class: Hydrogen
    Annotations: 
        <http://purl.obolibrary.org/obo/IAO_0000115> "Hydrogen is a chemical element with chemical symbol H and atomic number 1. It is used in water electrolysis during the power-to-gas process as a storage medium for excess electricty."@en,
        <http://purl.obolibrary.org/obo/IAO_0000119> "https://wiki.openmod-initiative.org/wiki/Hydrogen"@en
    SubClassOf: 
        EnergyStorage,
        has_disposition some Fuel,
        has_origin value synthetic

Hydrogen can be of fossil origin or of synthetic origin. Therefore I propose the following structure

Class: Hydrogen
  Definition: 
  SubClassOf:
    has_disposition some Fuel,
    has_normal_state_of_matter value gaseous

Class: FossilHydrogen
  Definition: "Fossil hydrogen is hydrogen with fossil origin. It is usually produced from fossil fuels applying the steam reforming process."
  SubClassOf:
    has_disposition some Fuel,
    has_normal_state_of_matter value gaseous,
    has_origin value fossil

Class: SyntheticHydrogen
  Definition: "Synthetic hydrogen is hydrogen with synthetic origin. It is usually produced from water applying the water electrolysis process."
  SubClassOf:
    SyntheticFuel,
    has_disposition some Fuel,
    has_normal_state_of_matter value gaseous,
    has_origin value synthetic

As you can see I skipped the definition of the class Hydrogen as I discovered here a little problem:

Hydrogen is currently defined as Hydrogen is a chemical element with chemical symbol H and atomic number 1. So this is the definition for the hydrogen element / atom.
But in energy system modeling we are usually not interested in the hydrogen element / atom but in the hydrogen gas which is composed from hydrogen molecules.

We might think about defining both classes HydrogenElement and HydrogenMolecule.

I deleted the SubClassOf: EnergyStorage as every fuel is an energy storage. But for the EnergyStorage class there is a separate issue #209.

In the definitions above I used technologies to differentiate the synthetic fuels:

PowerToGas: class already exists.
PowerToLiquid: new class to be defined
WaterElectrolysis: new class to be defined
SteamRefoming: new class to be defined

@stap-m @akleinau @jannahastings : What are you're thoughts?

akleinau commented 4 years ago

SyntheticHydrogen above has "has_origin value fossil" instead of synthetic. Do we need a HydrogenMolecule when its not important for energy system modeling? The rest sounds good.

l-emele commented 4 years ago

Thanks, I corrected my post above.

We probably do not need the hydrogen element but we definitely need the hydrogen gas.

stap-m commented 4 years ago

Why not making Hydrogen a subclass of portionOfMatter?

stap-m commented 4 years ago

'SyntheticMethane' and 'SyntheticLiquidFuel' would be subclasses of 'ElectricFuel', right? I.E.

Class: SyntheticMethane; SubClassOf: 'electricFuel'
Definition: "Synthetic methane is an ElectricFuel produced from water and carbon dioxide using electric energy applying the power-to-gas technology."`
has_origin value synthetic
has_normal_state_of_matter value gaseous`

Equivalent for class SyntheticLiquidFuel.

We could also call the parent class SyntheticFuel instead of electric?!

l-emele commented 4 years ago

I am okay with both SyntheticFuel and ElectricFuel. We can choose one and define the other as synonym.

l-emele commented 4 years ago

I changed my comment above according to comments by @stap-m.

Why not making Hydrogen a subclass of portionOfMatter?

Which hydrogen? The atom/element or the gas/molecule?

jannahastings commented 4 years ago

Which hydrogen? The atom/element or the gas/molecule?

What about having PortionOfHydrogenGas subClassOf PortionOfMatter ?

stap-m commented 4 years ago

Gas/Molecule - this is how Hydrogen is used and occurs in nature (H2, H2O,...). I'd actually like to discard the Hydrogen-element definition, I don't see why we'd need it in THIS ontology.

What about having PortionOfHydrogenGas subClassOf PortionOfMatter ?

We have 'has_normal_state_of_matter' as a property.

l-emele commented 4 years ago

I am fine with this. Any suggestions for a new definition of hydrogen?

akleinau commented 4 years ago

"PortionOfHydrogen is a PortionOfMatter with the molecular formula H2." with normal_state_of_matter gas?

stap-m commented 4 years ago

I am ok with this def for now. PR?

At some point we should discuss the focus of our PortionOfMatter class and review all the defs of its subclasses. Most of the defs are not Aristotelian yet and many are missing.

l-emele commented 4 years ago

I can implement what we discussed here in the next days. However we are only half finished as we still need definitions for these:

In the definitions above I used technologies to differentiate the synthetic fuels:

PowerToGas: class already exists.

PowerToLiquid: new class to be defined

WaterElectrolysis: new class to be defined

SteamRefoming: new class to be defined

akleinau commented 4 years ago

PowerToGas is not aristotelean and on the wrong place (EnergyStorage) so it should get a new def too. All of them are technologies so I'll classify them somewhere in the hierarchy there.

PowerToGas: a (EnergyStorage?)technology that converts electrical power to a gas fuel. PowerToLiquid: a (EnergyTransport?)Technology that converts the gas fuel of the PowerToGas technology to a liquid. WaterElectrolysis: A technology that uses an electric current to decompose water into hydrogen and oxygen gas. SteamReforming: A technology that produces syngas from hydrocarbons such as natural gas.

l-emele commented 4 years ago

PowerToGas and PowerToLiquid are not energy storage technologies but energy conversion technologies.

PowerToGas is ab energy conversion technology that converts electrical energy to a gaseous fuel.
PowerToLiquid is ab energy conversion technology that converts electrical energy to a liquid fuel.
WaterElectrolysis is an energy conversopm technology that uses an electric energy to decompose water into hydrogen and oxygen gas.

akleinau commented 4 years ago

Then we need a new class EnergyConversionTechnology: EnergyConversionTechnology is a technology that converts energy from one form to another.?

l-emele commented 4 years ago

I think this can be implemented. I'll do that.

l-emele commented 4 years ago

I've implemented synthetic fuel now: grafik

But for some reason it does not show up in the inferred view: grafik

@akleinau @stap-m : Any ideas what I've done wrong?

l-emele commented 4 years ago

Part of this issue is also to create the following technology classes:

PowerToGas
PowerToLiquid
WaterElectrolysis
SteamRefoming

However, we deleted all technology subclasses. Instead we could add energy converter classes:

power-to-liquid system: A power-to-liquid (often abbreviated P2L) system is an energy storage object that converts electrical power to a liquid fuel. => The power-to-liquid system would then be in parallel to the power-to-gas system.
water electrolyser: A water electrolyser is an energy converting device that uses an electric current to decompose water into hydrogen and oxygen gas. Electric energy is converted into chemical energy (and waste heat).
steam reformer: A steam reformer : A steam reformer is an energy converting device that produces syngas from hydrocarbons such as natural gas.

Power-to-gas system already exists. I do not like that it is an energy storage object and not an energy converting device, but that is a topic for an other issue. For the 0.0.1 I would stick with power-to-gas system being a energy storage object.

l-emele commented 4 years ago

Regarding the equivalent classes, this looks okay now with me. grafik

@stap-m @akleinau @jannahastings : Any objections against the proposed definitions for power-to-liquid system, water electrolyser and steam reformer in my last comment? If no-one vetoes until this afternoon, I'll include these classes as proposed.

akleinau commented 4 years ago

why is steam reformer a technology and not an artificial object?

l-emele commented 4 years ago

Sorry, that was a copy and paste error. It should also be an energy transformer. I corrected it above.

akleinau commented 4 years ago

then it all sounds good to me

OpenEnergyPlatform / ontology