OpenEnergyPlatform / ontology

Repository for the Open Energy Ontology (OEO)
Creative Commons Zero v1.0 Universal
105 stars 19 forks source link

Restructure class Generator #173

Closed stap-m closed 4 years ago

stap-m commented 4 years ago

Description of the issue

There are several issues on subclasses of class 'Generator' #159, #160, #161, #162 and the old issue #55.

  1. Before solving those issues, purpose, definition and classification of the class 'generator' should be discussed and updated. Right now, the def disagrees with severals of its subclasses, e.g. 'photovoltaic generator', 'geothermal generator', 'heat generator'.
  2. An agreement on the subclass structure should be found.

Ideas of solution

Workflow checklist

I am aware that

stap-m commented 4 years ago

The current def of 'Generator' is: A generator is a grid component that converts motive power (mechanical energy) into electrical power for use in an external circuit. Source: https://en.wikipedia.org/wiki/Electric_generator

akleinau commented 4 years ago

The EnArgus wiki (#179) has "Ein Generator wandelt mechanische Energie in elektrische Energie um." as a definition. This is identical to the current definition without the "for use in an external circuit" end

stap-m commented 4 years ago

Right now, generator is a subclass of 'artificial object'. I think this makes sense and is better, than making it a subclass of 'grid component'. Nevertheless, a generator can be (and usually is) also a grid component. Can we solve this with an equivalent class?

A generator is an artificial object that converts motive power (mechanical energy) into electrical power.

akleinau commented 4 years ago

Yes I just had a similar problem with model components in #196. We can make grid component an equivalent class defined as "every entity that is part of a grid"

akleinau commented 4 years ago

@stap-m, @l-emele is there a difference between a Generator and an EnergyGenerator and an ElectricityGenerator?

l-emele commented 4 years ago

A generator in general is a device that generates electricity (= electric energy). It does not necessary has to be from mechanical energy as there are also photovoltaic generators (see #162) and thermoelectric generators. Also a fuel cell can be seen as a a generator.

The generator that uses mechanical energy is usually called electric generator. As electric generators are by far the most common type of generators their name is usually shortened to generator. But for the ontology we should use the more precise names.

l-emele commented 4 years ago

We have decide on a crucial point regarding the definition of a generator:

I strongly prefer the first option but a lot of our generator subclasses (e.g. BiogasElectricityGenerator) follow the second logic.

We discussed this already a bit on the project meeting in Magdeburg in January 2019 but we came there to no final conclusion.

akleinau commented 4 years ago

I found the class PowerGeneratingUnit with no definition but the relations uses some EnergyGeneratorTechnology, EnergyStorageTechnology, EnergyTransferTechnology. Is that a synonym to Powerplant?

l-emele commented 4 years ago

In the current structure Powerplant and PowerGeneratingUnit are synonyms.

akleinau commented 4 years ago

what was the problem when discussing it 2019? I'd prefer the first one too.

l-emele commented 4 years ago

Simply the lack of time. We had a discussion on the ontology in general and stumbled over the generator and it's different possible definitions but had no time to find a general consensus.

stap-m commented 4 years ago

Yes, the first one.

l-emele commented 4 years ago

So we have a consensus on this long standing topic!

akleinau commented 4 years ago

ok subclasses of Generator right now are:

which ones have to be moved? (I didnt listed all subclasses for clarity)

stap-m commented 4 years ago

We need a def for Generator if we want to continue with its subclasses, e.g. in PR #235.

akleinau commented 4 years ago

@jannahastings, @MGlauer can you please add your pictures of the Whiteboard here?

jannahastings commented 4 years ago

IMG_7359 IMG_7358 IMG_7357 IMG_7356

MGlauer commented 4 years ago

image

akleinau commented 4 years ago

image

ok this will be the subclass-structure. This is complex enough that I think the best way is to make a pull request and work directly on the ontology. So I'll try to implement everything and see which problems occur.

First problem: I cant find a def for PowerGeneratingUnit?

akleinau commented 4 years ago
akleinau commented 4 years ago

image

is this the correct powerplant structure?

l-emele commented 4 years ago

If I remember correctly our discussion from last week, we decided to delete the class ReactivePowerplant.

Why do we have HydroPowerplants and HydroelectricPowerplants? This is confusing.

Some hydros are also renewable but not all, e.g. a PumpedStoragePlant without natural intake is not renewable.

MGlauer commented 4 years ago

image

ok this will be the subclass-structure. This is complex enough that I think the best way is to make a pull request and work directly on the ontology. So I'll try to implement everything and see which problems occur.

First problem: I cant find a def for PowerGeneratingUnit?

IIRC: We renamed EnergyConverter to PowerGeneratingUnit. This was also the reason why we did not rename EnergyTransformer to EnergyConverter yet. Otherwise it would clash with the former definition. Therefore we would rename GasEnergyConverter to GasPowerGeneratingUnit? (sound a bit weird to me)

l-emele commented 4 years ago

Therefore we would rename GasEnergyConverter to GasPowerGeneratingUnit? (sound a bit weird to me)

We might include fired in the class name. GasFiredPowerGeneratingUnit does not sound weird to mee.

stap-m commented 4 years ago

Why do we have HydroPowerplants and HydroelectricPowerplants? This is confusing.

We decided on leaving all hydro-related classes out for the moment. This is another huge area discussion.

stap-m commented 4 years ago

Oh no, I think we neither wrote down a def for PowerGeneratingUnit nor EnergyConverter/Transformer. But at least we discussed it well so it should be possible to recap. Here goes a first attempt:

l-emele commented 4 years ago

Why do we have HydroPowerplants and HydroelectricPowerplants? This is confusing.

We decided on leaving all hydro-related classes out for the moment. This is another huge area discussion.

Do we have an issue where we collect all water-related problems?

stap-m commented 4 years ago

We might include fired in the class name. GasFiredPowerGeneratingUnit does not sound weird to me.

I don't think each subclass of PowerGeneratingUnit needs the suffix PowerGeneratingUnit. We already have PVPanel that doesn't fit the scheme. What about GasFiredPowerUnit and WindDrivenPowerUnit ?

l-emele commented 4 years ago

In the pictures above there is the definition for energy converter: An energy converter is an artificial object that has part some generator (and other stuff).

l-emele commented 4 years ago

What about GasFiredPowerUnit and WindDrivenPowerUnit ?

I am probably fine with GasFiredPowerUnit. We have decided last week on WindEnergyConverter instead of WindDrivenPowerUnit .

stap-m commented 4 years ago

In the pictures above there is the definition for energy converter: An energy converter is an artificial object that has part some generator (and other stuff).

This def interfers with the def of generator: A generator is an energy transformer/converter that converts other forms of energy into eletrical energy. I.e. an energyConverter can transorm any type of energy into any type of energy.

stap-m commented 4 years ago

In the pictures above there is the definition for energy converter: An energy converter is an artificial object that has part some generator (and other stuff).

Now I also found this def on the foto. I think this def was made before we renamed energyConverter to PowerGeneratingUnit, where it fits. So at least we have a def for that one 😃

akleinau commented 4 years ago

What do we do with the hydro classes until we address them? delete them? put them away somewhere? just ignore them?

I don't like the "and other stuff" ending of the power generating unit def. What about: A power generating unit is an artificial object that contains a generator amongst other parts."?

akleinau commented 4 years ago

Do we have an issue where we collect all water-related problems?

we have just two water issues so we can just concentrate discussion in one of them, e.g. #43

akleinau commented 4 years ago

What about GasFiredPowerUnit and WindDrivenPowerUnit ?

I am probably fine with GasFiredPowerUnit. We have decided last week on WindEnergyConverter instead of WindDrivenPowerUnit .

the name "WindEnergyConverter" will be confusing as soon as we rename EnergyTransformer to EnergyConverter

l-emele commented 4 years ago

This is not confusing but intended: The WindEnergyConverter is that EnergyConverter that uses WindEnergy.

stap-m commented 4 years ago

Actually the def has to be:, A Wind energy converter is the Power Generating Unit that uses wind energy.

I made an overview with defs: grafik

l-emele commented 4 years ago

One important point in the definition of energy converter is missing: That an energy converter is a device. This word is important to distinguish the levels.

In the protocol we mention the word device explicitly.

Proposal: An energy converter is a device that transforms or changes a certain type of energy.

BTW: What is the difference between a transformation of energy and a change of energy?

akleinau commented 4 years ago

@l-emele what should do with the subclasses of ReactivePowerplant: HydrogenPowerplant and NuclarPowerplant. Delete?

l-emele commented 4 years ago

I propose delete ReactivePowerplant but make HydrogenPowerplant and NuclearPowerPlant direct subclasses of PowerPlant.

akleinau commented 4 years ago

image ok then I have this Powerplant hierarchy (with HydroPowerplant being ignored and looked at later)

l-emele commented 4 years ago

To almost all fuels there is an equivalent PowerPlant and PowerGenerationUnit, e.g.

How do we deal with this efficiently? I think could do there a lot by infering.

@jannahastings: Any thoughts?

l-emele commented 4 years ago

The class FieldPhotovoltaicGenerator should be renamed as we defined generator differently. Next to FieldPhotovoltaikPowerPlant I would suggest solar park and solar farm at least as synonyms.

I would be also okay to name it directly solar park, that is a term that is used quite often and is somehow the equivalent term to wind farm. https://en.wikipedia.org/wiki/Photovoltaic_power_station

akleinau commented 4 years ago

We do have a lot of redundancy with the Powerplants and PowerGeneratingUnits and Generators. I personally don't see a more efficient way than just implementing those redundancies, especially because if I understand it correctly there's information added each level. E.g. a WindElectricityGenerator is used in several kind of WindFarms: eg. OffShoreWindFarm and OnShoreWindFarm

akleinau commented 4 years ago

under Generator we have a class BioElectricityGenerator with subclasses Biogas- and BiomassElectricityGenerator. Am I right that we have accordingly also that structure in PowerGeneratingUnit and Powerplant?

akleinau commented 4 years ago

image

my current structure

l-emele commented 4 years ago

A couple of things I spotted from those screenshots:

l-emele commented 4 years ago

under Generator we have a class BioElectricityGenerator with subclasses Biogas- and BiomassElectricityGenerator. Am I right that we have accordingly also that structure in PowerGeneratingUnit and Powerplant?

These classes are not generators any more according to our more precise definition. They need to be renamed and to be redefined. The lables could be something like BiofuelPowerplant with subclasses BiogasPowerPlant and SolidBiomassPowerPlant.

akleinau commented 4 years ago

So are there any more generators than Electromotive and PVCell?

l-emele commented 4 years ago

FuelCell is a generator. I don't know whether we have already FuelCell in our ontology. If not, we should include it.