OpenEnergyPlatform / ontology

Repository for the Open Energy Ontology (OEO)
Creative Commons Zero v1.0 Universal
106 stars 23 forks source link

change study subregion #1746

Closed viktorwichern closed 11 months ago

viktorwichern commented 11 months ago

Description of the issue

Right now, subregion is a subclass of spatial region and has only one child, study subregion.

study subregion is defined as: A study subregion is a subregion of a study region. but has no relation to study region, neither through inheritance nor axiom.

Are subregion and study subregion important for the ontology? If the changes from Issue #1745 will be implemented, study subregion has to be edited as well.

This is a little bit confusing, I offer a solution below but I am not sure, since subregion is defined as a spatial region that is part of a spatial region, so theoretically, a subregion could be bearer of the study region role as well, which would make the distinction obsolete. This may be related to the seemingly circular definition of subregion.

Ideas of solution

Change study subregion into a role.

study subregion role definition: The study subregion role is the role of a subregion that is under investigation and is part of a spatial region with the study region role.

'subregion' and 'part of' 'spatial region' and 'has role' some 'study region role'

Workflow checklist

I am aware that

l-emele commented 11 months ago

I think having those role is a good idea. However, I think we should add these additionally and not instead of the existing classes. We should keep then the existing classes as equivalent classes.