search

OpenEnergyPlatform / ontology

Repository for the Open Energy Ontology (OEO)
Creative Commons Zero v1.0 Universal
105 stars 19 forks source link

update iao import #1700 #1754

Closed stap-m closed 7 months ago

stap-m commented 7 months ago

Summary of the discussion

Based on #1700 and #1755 and #1756 and #1651 and #1695 and #1689

Type of change (CHANGELOG.md)

Add

http://purl.obolibrary.org/obo/IAO_0000582 # time stamped measurement datum http://purl.obolibrary.org/obo/IAO_0000007 # action specification http://purl.obolibrary.org/obo/IAO_0000098 # data format specification http://purl.obolibrary.org/obo/IAO_0000005 # objective specification http://purl.obolibrary.org/obo/OBI_0500000 # study design http://purl.obolibrary.org/obo/IAO_0000594 # software application http://purl.obolibrary.org/obo/IAO_0000593 # software library http://purl.obolibrary.org/obo/IAO_0000591 # software method http://purl.obolibrary.org/obo/IAO_0000592 # software module http://purl.obolibrary.org/obo/IAO_0000595 # software script http://purl.obolibrary.org/obo/IAO_0000314 # document part # subclasses requireds? http://purl.obolibrary.org/obo/IAO_0000013 # journal article http://purl.obolibrary.org/obo/IAO_0000129 # version number http://purl.obolibrary.org/obo/IAO_0000400 # cartesian spatial coordinate datum http://purl.obolibrary.org/obo/IAO_0000401 # one dimensional cartesian spatial coordinate datum http://purl.obolibrary.org/obo/IAO_0000402 # two dimensional cartesian spatial coordinate datum http://purl.obolibrary.org/obo/IAO_0000403 # three dimensional cartesian spatial coordinate datum http://purl.obolibrary.org/obo/IAO_0000581 # has time stamp

Automation

Closes #1755, #1700

PR-Assignee

Reviewer

stap-m commented 7 months ago

Note: since we included has time stamp with hierarchy, we have its parent property has part imported twice, once by IAO and once by RO.

EDIT: see https://github.com/OpenEnergyPlatform/oeo-tools/issues/5 for the import procedure. For the immediate solution, I remove it in ro-extracted.owl

stap-m commented 7 months ago

I just saw, the the newly imported journal article has two parents, report and pubclication. How do we deal with that? I'd vote for removing either of them and comment in oeo-import-edits.

stap-m commented 7 months ago

Todo: clean oeo-import-edits. I'll do that in a separate issue once this PR is merged, for a better reviewability.

stap-m commented 7 months ago

I just saw, the the newly imported journal article has two parents, report and pubclication. How do we deal with that? I'd vote for removing either of them and comment in oeo-import-edits.

Thanks for the review. Any opinion on this @l-emele ?

stap-m commented 7 months ago

I just saw, the the newly imported journal article has two parents, report and pubclication. How do we deal with that? I'd vote for removing either of them and comment in oeo-import-edits.

Thanks for the review. Any opinion on this @l-emele ?

From todays oeo-dev-meeting: try to skip the import of publication and have only the already imported class report as parent

areleu commented 7 months ago

I could not reproduce the extraction process 1 to 1, did you do some manual changes after extracting or am I missing something?

stap-m commented 7 months ago

I could not reproduce the extraction process 1 to 1, did you do some manual changes after extracting or am I missing something?

Can you specify the diffs? I ran the script pushed in this commit: https://github.com/OpenEnergyPlatform/oeo-tools/pull/4/commits/b1cd5d4ec6b61c69cd8eeb453270053ab11e1e69 All other changes have been done in oeo-import-edits.

stap-m commented 7 months ago

I could not reproduce the extraction process 1 to 1, did you do some manual changes after extracting or am I missing something?

Can you specify the diffs? I ran the script pushed in this commit: OpenEnergyPlatform/oeo-tools@b1cd5d4 All other changes have been done in oeo-import-edits.

@areleu could you also review this PR https://github.com/OpenEnergyPlatform/oeo-tools/pull/4 please.

areleu commented 7 months ago

I could not reproduce the extraction process 1 to 1, did you do some manual changes after extracting or am I missing something?

Can you specify the diffs? I ran the script pushed in this commit: OpenEnergyPlatform/oeo-tools@b1cd5d4 All other changes have been done in oeo-import-edits.

Just checked it out, and I could reproduce the imports

I could not reproduce the extraction process 1 to 1, did you do some manual changes after extracting or am I missing something?

Can you specify the diffs? I ran the script pushed in this commit: OpenEnergyPlatform/oeo-tools@b1cd5d4 All other changes have been done in oeo-import-edits.

@areleu could you also review this PR OpenEnergyPlatform/oeo-tools#4 please.

I guess this check works as validation of this too.