Add `market share` and `market share value`

OpenEnergyPlatform / ontology

Repository for the Open Energy Ontology (OEO)

Creative Commons Zero v1.0 Universal

105 stars 19 forks source link

Add `market share` and `market share value` #1779

Closed chrwm closed 7 months ago

chrwm commented 7 months ago

Summary of the discussion

I added the terms to the shared-axioms-module.

Type of change (CHANGELOG.md)

Add

Added market share
Added market share value

Workflow checklist

Automation

Closes #1636

PR-Assignee

[x] 🐙 Follow the Pull Request Workflow
[x] 📝 Update the CHANGELOG.md
[x] 📙 Add #'s to term tracker item

Reviewer

[ ] 🐙 Follow the Reviewer Guide
[ ] 🐙 Provided feedback and show sufficient appreciation for the work done

stap-m commented 7 months ago

I added the terms to the shared-axioms-module.

This module is only for axioms across modules! Is there a reason, why not oeo-social?

chrwm commented 7 months ago

I added the terms to the shared-axioms-module.

This module is only for axioms across modules! Is there a reason, why not oeo-social?

No, it seemed for me that in the future it might intertwine with other concepts of other modules. However, I can move it over to oeo-social for now.

stap-m commented 7 months ago

I added the terms to the shared-axioms-module.

This module is only for axioms across modules! Is there a reason, why not oeo-social?

No, it seemed for me that in the future it might intertwine with other concepts of other modules. However, I can move it over to oeo-social for now.

In that case, the axioms will be implemented in oeo-shared-axioms, but the classes should stay at their "home module".