OpenEnergyPlatform / ontology

Repository for the Open Energy Ontology (OEO)
Creative Commons Zero v1.0 Universal
111 stars 23 forks source link

[meta] review RO imports and (conservative?) extensions #1783

Open stap-m opened 11 months ago

stap-m commented 11 months ago

Description of the issue

Background

Current state / ToDos:

Ideas of solution

If you already have ideas for the solution describe them here

Workflow checklist

I am aware that

h-spinde commented 8 months ago

For ease of discussion, here an overview of the current differences between ranges & domains in the RO vs how they are imported in the OEO:

Class Domain in RO Domain in OEO import Range in RO Range in OEO import
BFO_0000054 (realized in) realizable entity process
RO_0003001 (produced by) material entity material entity
RO_0003000 (produces) material entity material entity
BFO_0000062 (preceded by) occurrent occurrent
BFO_0000063 (precedes) occurrent occurrent
RO_0002091 (starts during) occurrent occurrent
RO_0000053 (has characteristic/bearer of) energy or independent continuant specifically dependent continuant specifically dependent continuant
RO_0000087 (has role) independent continuant energy or idependent continuant role role
RO_0000086 (has quality) continuant quality quality
RO_0001025 (located in) independent continuant and (not (spatial region))* independent continuant independent continuant and (not (spatial region))* independent continuant
RO_0002501 (causal relation between processes) occurent process occurent process
RO_0002410 (causally related to) process or material entity process or material entity

*Note: The RO also contains a redundant axiom listing "independent continuant" seperately here, specifically to make the RO easier to use with reasoners that cannot handle negation

Most of the domains/ranges are defined in oeo-import-edits, however RO_0000053 (bearer of) and RO_0002410 (causally related to) have their domains and ranges defined in oeo-shared, and while the range of RO_0000087 (has role) is defined in oeo-import-edits, its domain is defined in oeo-shared. As an additional note: "has input" used to have a defined range within the OEO (for reference see pull request 702), but this axiom is now missing. If this was a deliberate decision, the discussion should probably be added to the term tracker.