import `characteristic of` from RO

OpenEnergyPlatform / ontology

Repository for the Open Energy Ontology (OEO)

Creative Commons Zero v1.0 Universal

105 stars 19 forks source link

import `characteristic of` from RO #1794

Closed stap-m closed 1 month ago

stap-m commented 5 months ago

Description of the issue

We currently import has characteristic from RO, but not its inverse characteristic of. Instead we defined our own relation has bearer. It is good practice to reuse extisting relations and terms, especially from well-established and widely used ontologies like RO. Therefore, we should think about replacing has bearer with characteristic of.

Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

l-emele commented 5 months ago

I agree that we should import characteristic of from RO. But as has bearer is currently used more than 100 times I suggest that we do no replace our has bearer with characteristic of but instead declare has bearer as equivalent to characteristic of. This avoids the tedious work of adapting so many axioms.

l-emele commented 5 months ago

Maybe we should import this whole branch of object properties: grafik

stap-m commented 4 months ago

I agree that we should import characteristic of from RO. But as has bearer is currently used more than 100 times I suggest that we do no replace our has bearer with characteristic of but instead declare has bearer as equivalent to characteristic of. This avoids the tedious work of adapting so many axioms.

I think this is rather a find-and-replace job and managable. But we can discuss this in a meeting.

l-emele commented 4 months ago

I think this is rather a find-and-replace job and managable. But we can discuss this in a meeting.

Only if you neglect the term trackers... It put in on the agenda for the next OEO dev meeting.

areleu commented 3 months ago

From Dev meeting 76:

Aufgaben:

Import "characteristic of" from RO with subproperties

disposition of

function of

quality of

role of

Add equivalence with "has bearer"
Replace?

Wer macht es? @areleu (@stap-m , kannst du unterstützen und nochmal den workflow erklären?)

stap-m commented 3 months ago

I can do the import and you do the integration/mapping within OEO @areleu?

areleu commented 3 months ago

I can do the import and you do the integration/mapping within OEO @areleu?

Sure, I also wanted to understand how should the oeo-tools used now. Should it be cloned inside the OEO repo?

stap-m commented 3 months ago

Ok. Here's the workflow

Update list of terms to be imported in oeo-tools repo
Run script in oeo-tools repo
PR in oeo-tools repo
Copy xxx-extracted.owl to oeo-repo and check new import in oeo
PR in oeo repo
Reference PRs and issues in both repos for transparency.