Annotation OEO_00140170 shows not properly in oeo-physical

OpenEnergyPlatform / ontology

Repository for the Open Energy Ontology (OEO)

Creative Commons Zero v1.0 Universal

105 stars 19 forks source link

Annotation OEO_00140170 shows not properly in oeo-physical #1802

Closed l-emele closed 2 months ago

l-emele commented 5 months ago

Description of the issue

Annotation OEO_00140170 shows not properly in oeo-physical, which means that it is used but not properly imported: grafik

Ideas of solution

If you already have ideas for the solution describe them here

Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

l-emele commented 5 months ago

OEO_00140170 is the annotation property has documentation quality. It is implemented in oeo-model and has a domain of model.

It shows up in oeo-physical only when opening oeo.omn first and then switching to oeo-physical. When opening oeo-physical directly, OEO_00140170 does not show up. So this seems not to be a problem of the OEO but instead a bug in Protégé.

stap-m commented 5 months ago

Well spotted. I can reproduce the bug.

Reading the definition, I think OEO_00140170 should be a data property, instead. Annotation properties are used to annotate oeo entities, not models.

stap-m commented 3 months ago

Reading the definition, I think OEO_00140170 should be a data property, instead. Annotation properties are used to annotate oeo entities, not models.

Any comments? We should fix this rather soon.

l-emele commented 3 months ago

So we convert this to a data property? I am fine with that.