search

OpenEnergyPlatform / ontology

Repository for the Open Energy Ontology (OEO)
Creative Commons Zero v1.0 Universal
105 stars 19 forks source link

Added Characteristic of #1838

Closed areleu closed 1 month ago

areleu commented 2 months ago

Summary of the discussion

Deals with https://github.com/OpenEnergyPlatform/ontology/issues/1794

Type of change (CHANGELOG.md)

Add

Workflow checklist

Automation

Closes #1794

PR-Assignee

Reviewer

areleu commented 2 months ago

When running the script a bunch of annotations from has part came through, is it something to worry about?

stap-m commented 2 months ago

grafik Very interesting comment, btw. This could spare us some headaches...

stap-m commented 2 months ago

When running the script a bunch of annotations from has part came through, is it something to worry about?

IAO and RO both import has part from BFO. We should delete it again from the RO import to avoid duplicate annotations. grafik

areleu commented 2 months ago

Now this, some of the super classses of characteristic of are coming with the import, should we import it without its tree?

stap-m commented 2 months ago

Now this, some of the super classses of characteristic of are coming with the import, should we import it without its tree?

Yes, I think we don't need the full hierarchy.

stap-m commented 1 month ago

I have the impression that we can improve the import. However this requires some more time.

1844 waits for the completion of this PR. Therefore, if there are no severe bugs, I'd like to merge this now. @areleu @nelekoehler @l-emele can someone else take a look please?

nelekoehler commented 1 month ago

The imported object properties look good to me. I didn't recognize any bugs concerning them.