OpenEnergyPlatform / ontology

Repository for the Open Energy Ontology (OEO)
Creative Commons Zero v1.0 Universal
105 stars 19 forks source link

Add class "quantity" #1510 #1839

Closed nelekoehler closed 2 months ago

nelekoehler commented 2 months ago

Summary of the discussion

As described in #1510 and #1752 we want to restructure quantity values. Therefore we need a class "quantity", which I added in this pull request. The definition has been derived from the International vocabulary of metrology — Basic and general concepts and associated terms (VIM). Based on this implementation some existing entities have to be reclassified in following PRs.

Add

Workflow checklist

PR-Assignee

Reviewer

stap-m commented 2 months ago

Looks good. We might add the axiom quantity 'has quantity value' some 'quantity value'.

l-emele commented 2 months ago

Looks good. We might add the axiom quantity 'has quantity value' some 'quantity value'.

Are there quantities which cannot have quantity values? I don't think so. Thus I suggest to make it an equivalent class: quantity EquivalentTo: quality and 'has quantity value' some 'quantity value'.