Add `industrial technology` and `industrial plant`

OpenEnergyPlatform / ontology

Repository for the Open Energy Ontology (OEO)

Creative Commons Zero v1.0 Universal

105 stars 19 forks source link

Add `industrial technology` and `industrial plant` #1840

Open l-emele opened 2 months ago

l-emele commented 2 months ago

Summary of the discussion

Describe the findings of the discussion in the issue or meeting.

Type of change (CHANGELOG.md)

Add

Added a new class #

Update

Updated a definition #

Remove

Removed a broken link #

Workflow checklist

Automation

Closes #1726

PR-Assignee

[ ] 🐙 Follow the Pull Request Workflow
[ ] 📝 Update the CHANGELOG.md
[ ] 📙 Add #'s to term tracker item

Reviewer

[ ] 🐙 Follow the Reviewer Guide
[ ] 🐙 Provided feedback and show sufficient appreciation for the work done

stap-m commented 1 month ago

What is the state of this PR? Can you finish it until the release @l-emele?

l-emele commented 1 month ago

What is the state of this PR? Can you finish it until the release @l-emele?

I don't think so. My implementation has led to some inconsistencies (see failing CI run). The problem is that classes introduced at different stages do not align, see issue discussion. I don't see a quick fix for this.

l-emele commented 5 days ago

I implemented the industry technology axiom wrong and that is why the CI was failing. I fixed this and it is now working again.

However, I want to discuss some further things related to the industry classes, see issue #1726.