Simplify domain and range of `is traded at` and `trades` #1239 - Githubissues

OpenEnergyPlatform / ontology

Repository for the Open Energy Ontology (OEO)

Creative Commons Zero v1.0 Universal

111 stars 23 forks source link

Simplify domain and range of `is traded at` and `trades` #1239 #1912

Closed l-emele closed 2 months ago

l-emele commented 2 months ago

Summary of the discussion

Introducing a class product enables to simplify the object properties is traded at and trades.

Type of change (CHANGELOG.md)

Add

product: A product is a continuant that is either a good or a service product.
- product EquivalentTo: good or 'service product'

Update

is traded at: Is traded at is a relation that holds between a product and a market exchange where the product is offered for trade/sale at the market exchange.
- domain: product
- range: market exchange
trades: A relation that holds between a product and a market exchange.
- domain: market exchange
- range: product

Workflow checklist

Automation

Closes #1239 Also implements parts of (product) from #1514

PR-Assignee

[ ] 🐙 Follow the Pull Request Workflow
[ ] 📝 Update the CHANGELOG.md
[ ] 📙 Add #'s to term tracker item

Reviewer

[ ] 🐙 Follow the Reviewer Guide
[ ] 🐙 Provided feedback and show sufficient appreciation for the work done

l-emele commented 2 months ago

I've implemented now as discussed in oeo dev meeting 87. @stap-m : please review again.