replaced more term tracker items with annotation #1850

OpenEnergyPlatform / ontology

Repository for the Open Energy Ontology (OEO)

Creative Commons Zero v1.0 Universal

111 stars 23 forks source link

replaced more term tracker items with annotation #1850 #1923

Closed madbkr closed 2 months ago

madbkr commented 2 months ago

Summary of the discussion

This is a follow-up PR of #1922 See issue #1850

Type of change (CHANGELOG.md)

Update

Replaced missing term tracker item with term tracker annotation in

oeo-import-edits.owl
oeo-physical-axioms.owl
oeo-shared-axioms.omn

Workflow checklist

Automation

Closes #1850

PR-Assignee

[x] 🐙 Follow the Pull Request Workflow
[x] 📝 Update the CHANGELOG.md
[x] 📙 Add #'s to term tracker item

Reviewer

[ ] 🐙 Follow the Reviewer Guide
[ ] 🐙 Provided feedback and show sufficient appreciation for the work done

l-emele commented 2 months ago

In oeo-shared-axioms.omn there are also a couple of term tracker item left. grafik

stap-m commented 2 months ago

grafik

We have owl files now, not omn files. Therefore, the replacement has to consider the prefixes as well. IAO has an obo prefix, but the new oeo class needs an oeo prefix, which is not there yet. @madbkr do you want to try fixing this or should we take a look together on monday?

madbkr commented 2 months ago

I replaced everything in 'oeo-shared-axioms.omn' now. I also tried to fix the prefixed by replacing obo:OEO_00020426 with oeo:OEO_00020426. But since a check failed this obviously didn't work as planned. So yes, I'd be happy to look at it on monday. @stap-m Maybe oeo:OEO_00020426 is missing a declaration?

l-emele commented 2 months ago

I also tried to fix the prefixed by replacing obo:OEO_00020426 with oeo:OEO_00020426. But since a check failed this obviously didn't work as planned.

As the OEO is imported as base, OEO entities should probably not have any prefix.

stap-m commented 2 months ago

As the OEO is imported as base, OEO entities should probably not have any prefix.

Yes, for oeo-shared-axioms. For oeo-import-edits we need an oeo prefix, I guess. EDIT: and as well for oeo-physical-axioms.

l-emele commented 2 months ago

Were all changes related to the term trackers done with a simple text editor and not with Protégé? Then it would be good to run the changes through Protégé that Protégé can do all the rearrangements.

Else, future PR gets cluttered with rearrangements and the intentional changes of these future PRs get obfuscated.

stap-m commented 2 months ago

@madbkr We have a release planned for Tuesday and there are some PRs waiting for these changes, therefore I declared the prefixes and made protege rearrange the files by minor changes. I'll now review. @l-emele can you please also review?