replaced 'has bearer' with 'characteristic of'

OpenEnergyPlatform / ontology

Repository for the Open Energy Ontology (OEO)

Creative Commons Zero v1.0 Universal

111 stars 23 forks source link

replaced 'has bearer' with 'characteristic of' #1928

Closed LillyG901 closed 1 month ago

LillyG901 commented 2 months ago

Summary of the discussion

See issue #1907.

Type of change (CHANGELOG.md)

Update

replaced 'has bearer' with 'characteristic of' in

oeo-model.omn
oeo-physical.omn
oeo-shared-axioms.omn
oeo-shared.omn
oeo-social.omn

Workflow checklist

Automation

Closes #1907

PR-Assignee

[x] 🐙 Follow the Pull Request Workflow
[x] 📝 Update the CHANGELOG.md
[x] 📙 Add #'s to term tracker item

Reviewer

[x] 🐙 Follow the Reviewer Guide
[x] 🐙 Provided feedback and show sufficient appreciation for the work done

LillyG901 commented 2 months ago

CHANGELOG.md Version [2.X.X] contains two "Changed" Sections. Is this on purpose?

LillyG901 commented 2 months ago

term tracker annotations were added during commit: 'replaced 'has bearer' with 'characteristic of' in all omn-files'

l-emele commented 2 months ago

CHANGELOG.md Version [2.X.X] contains two "Changed" Sections. Is this on purpose?

I created PR #1930 to fix this

stap-m commented 2 months ago

I'd suggest to also make has bearer obsolete. @l-emele what do you think?

l-emele commented 2 months ago

I'd suggest to also make has bearer obsolete. @l-emele what do you think?

I am fine with that.

stap-m commented 2 months ago

@LillyG901 for the obsoletion you can check how I did that in #1931. In the comment you can put "The relation was replaced by RO_0000052 (characteristic of). Please use this relation ans its subrelations in the future."