OpenEnergyPlatform / ontology

Repository for the Open Energy Ontology (OEO)
Creative Commons Zero v1.0 Universal
106 stars 23 forks source link

Add (sub)sector individuals for sectors from IPCC sector division #461

Closed l-emele closed 3 years ago

l-emele commented 4 years ago

Description of the issue

From OEO DEV Meeting 7: Add sector and subsector individuals for sectors from IPCC sector divisions

Ideas of solution

Workflow checklist

I am aware that

l-emele commented 4 years ago

Probably best to solve #460 before.

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 4 years ago

Can you give a reference to the sector definition?


Also, I think it could we valuable to discuss this at least while #460 is still pending. We don't expect any fundamental changes there (the issue is titled "rename …"), no?

l-emele commented 4 years ago

The currently valid 2006 IPCC guidelines can be found here: https://www.ipcc-nggip.iges.or.jp/public/2006gl/index.html The definitions are scattered across these guidelines which are collection of documents.

Each of the sectors has a label and a systematic label showing its position in the subsector tree structure.

One example is the sector Energy Industries has the systematic label 1.A.1 indicating that it is a subsector of a sector Fuel combustion with the systematic label 1.A which itself is a subsector of a sector Energy with the systematic label 1. Its definition can be found in volume 2, chapter 2 as: Comprises emissions from fuels combusted by the fuel extraction or energy-producing industries. @jannahastings : For these systematic labels like 1.A.1, do we want to use the annotation alternative term or do we want to create a new annotation type?

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q : We a long discussion last week on sectors, #460 and #461 are results of this. It is probably easier if we solve #460 first, but #461 definitely be solved soon, too.

jannahastings commented 4 years ago

@jannahastings : For these systematic labels like 1.A.1, do we want to use the annotation alternative term or do we want to create a new annotation type?

Let's create a new annotation type just for these so that we can be clearer about what these mean and where they come from. We can make it a sub-annotation-property of 'alternative term'.

l-emele commented 4 years ago

What about something like a unique individual identifier with the following definition: A unique individual identifier is an alternative term that is unique for one individual of a class. Unique individual identifiers follow usually a structure defined e.g. by a sector division.

If we define it generically like my proposal we can in future use it also for other individuals. E.g. Eurostat uses codes for energy carriers (example: https://ec.europa.eu/eurostat/ramon/nomenclatures/index.cfm?TargetUrl=DSP_GLOSSARY_NOM_DTL_VIEW&StrNom=CODED2&IntKey=16416335).

l-emele commented 4 years ago

Probably best to solve #460 before.

460 is solved, so we could proceed there.

What about something like a unique individual identifier with the following definition: A unique individual identifier is an alternative term that is unique for one individual of a class. Unique individual identifiers follow usually a structure defined e.g. by a sector division.

@jannahastings : If you agree with my proposal above I will implement this and start adding some sector individuals.

jannahastings commented 4 years ago

Basically I agree. However, I think the parent for this entity should be 'identifier' in IAO:

http://www.ontobee.org/ontology/IAO?iri=http://purl.obolibrary.org/obo/IAO_0020000

The definition might be able to be abbreviated slightly if it is based on this parent.

l-emele commented 4 years ago

Sounds good. If we import identifier from IAO this will be an entity. But the intended use is as an annotation property. Does that work?

We also have the annotation property dc:identifier which might be a parent. But it has no definition.

jannahastings commented 4 years ago

Ah, okay, sorry, yes. Then I think it might be better as a sub-property of dc:identifier, even though that doesn't have a definition.

l-emele commented 4 years ago

So then the definition would be: A unique individual identifier is an identifier that is unique for one individual of a class. Unique individual identifiers follow usually a structure defined e.g. by a sector division.?

l-emele commented 4 years ago

Unfortunately I did not manage to finalise this issue before my summer holidays. I successfully merged the dev branch into my branch feature/sector-division-#461 without any merge conflicts. But my new annotation property unique individual identifier (OEO_00010037) does not show up any more in Protégé and and my sector individuals do not show up either.

Looking into a branch compare I did not find any errors: https://github.com/OpenEnergyPlatform/ontology/compare/feature/sector-division-%23461

@jannahastings : Any ideas?

sfluegel05 commented 4 years ago

The problem is that you used the Object Property is_defined_by for your sector individuals which got replaced by OEO_00000504 when you merged the dev into your branch. So hopefully replacing is_defined_by with OEO_00000504 for the individuals should do the trick.

l-emele commented 4 years ago

To do: PR for the current state (after the problem is solved) as we need the annotation property for 1.1 release and for other issues. The individuals can wait, so let the issue open after the PR.

l-emele commented 4 years ago

Thank you, @sfluegel05. Your solutions seems to have worked.

l-emele commented 4 years ago

For the individuals I propose the following structure:

For the IPCC sector individuals that could look like:

@jannahastings @stap-m : Do you agree?

jannahastings commented 4 years ago

I agree! The proposed texts look clear and informative to me.

l-emele commented 4 years ago

We discussed to link the sector individuals with has part relations. But I am only able to use that relation between classes and cannot apply it to individuals. grafik

Any ideas, @jannahastings ?

l-emele commented 4 years ago

I found it, I looked on the wrong place: grafik

jannahastings commented 4 years ago

Great. Well spotted! Protege's user interface is not always the most intuitive :-/

l-emele commented 3 years ago

Just discussed with @stap-m via phone some improvements to clarify the that there are slight differences between the (theoretical) IPCC guidelines and the actual use in greenhouse gas inventories and data, which is relevant for modelling.