OpenEnergyPlatform / ontology

Repository for the Open Energy Ontology (OEO)
Creative Commons Zero v1.0 Universal
109 stars 23 forks source link

hydrocarbon and syngas should be included #786

Closed sfluegel05 closed 3 years ago

sfluegel05 commented 3 years ago

Description of the issue

this comes from #761

The definition of steam reformer references both hydrocarbon and syngas. Therefore, it would be useful to have them as concepts in our ontology and connect them to steam transformer. A steam reformer is an energy converting device that produces syngas from hydrocarbons such as natural gas.

Hydrocarbon also appears in the definitions of several material entities.

Ideas of solution

Workflow checklist

I am aware that

l-emele commented 3 years ago

Why do you suggest for syngas material entity and not portion of matter as parent class? We already have other gas mixtures as portion of matter, notably air.

Apart from that I agree to your proposals.

sfluegel05 commented 3 years ago

I don't have a reason for this, I assume this was just a mistake. I corrected that now and also made the definitions aristotelian: Syngas is a portion of matter which is a fuel gas mixture consisting primarily of hydrogen, carbon monoxide, and very often some carbon dioxide. Hydrocarbon is a portion of matter which is member of class of organic chemical compounds composed only of the elements carbon (C) and hydrogen (H).