search

OpenEnergyPlatform / open-MaStR

A collaborative software to download the energy database Marktstammdatenregister (MaStR)
https://open-mastr.readthedocs.io/en/latest/
GNU Affero General Public License v3.0
87 stars 19 forks source link

Prevent install of SQLA>=2.0 #404

Closed nesnoj closed 1 year ago

nesnoj commented 1 year ago

Until #403 is solved, the install of SQLAlchemy>=2 should be avoided. This is important right now since there's some strange behaviour:

  1. Install via pypi (virtualenv): installs SQLAlchemy==1.4.45 :heavy_check_mark:
  2. Manual install via pip -e path/to/cloned/repo/ (virtualenv): installs SQLAlchemy==1.4.45 :heavy_check_mark:
  3. Manual install via python setup.py install (virtualenv and conda): installs SQLAlchemy==2.0.0b4 :no_entry: -> reason for #395

2.+3. should have the same result, but something goes wrong using the 3rd way. Same with conda - the standard way described in the readme. Only pinning to sqlalchemy<2.0 works out.

I think it does no harm if we pin it to <2 until #403 is completed. What do you think, @deniztepe?

nesnoj commented 1 year ago

Alternatively, the installation via pip install -e ... could replace the current instructions but that's not really failsafe..

deniztepe commented 1 year ago

Closed with #405