Change while loop to for loop

[jessymatar]

Summary of the discussion

With a for loop, we could run a specific number of iterations unlike while. Also it is a test run to get to know the techniques with pull request.

Type of change (CHANGELOG.md)

Updated

• Replace the while loop with for loop in the xml_download file

Workflow checklist

PR-Assignee

• [ ] 🐙 Follow the workflow in CONTRIBUTING.md
• [ ] 📝 Update the CHANGELOG.md
• [ ] 📙 Update the documentation

Reviewer

• [ ] 🐙 Follow the Reviewer Guidelines
• [ ] 🐙 Provided feedback and show sufficient appreciation for the work done

[FlorianK13]

@chrwm Do you understand why those tests are failing?

[FlorianK13]

@chrwm @jessymatar I finally figured out why those tests are failing: Github Secrets are not passed to Workflows from Pull Requests coming from forks (for security reasons). Hence these tests cannot use the API credentials and hence the tests fail. How should we proceed here @chrwm ?

[FlorianK13]

This is also implemented in #470