search

OpenEnergyPlatform / open-MaStR

A collaborative software to download the energy database Marktstammdatenregister (MaStR)
https://open-mastr.readthedocs.io/en/latest/
GNU Affero General Public License v3.0
87 stars 19 forks source link

Identify as open-mastr package when requesting data from marktstammdatenregister.de #489

Closed FlorianK13 closed 5 months ago

FlorianK13 commented 7 months ago

We could add a small identification in the request header to identify as python package user when the data is requested from BNetzA.

maurerle commented 6 months ago

This should be done setting by setting a User-Agent like open-mastr/x.x requests/y.y python/z.z in the requests call and similar to the header in: https://github.com/OpenEnergyPlatform/open-MaStR/blob/production/open_mastr/xml_download/utils_download_bulk.py#L125

FlorianK13 commented 6 months ago

@maurerle I also think this is the right approach. Due to limited resources this was not done yet. If you wish to contribute we are always happy about Pull Requests :)

maurerle commented 5 months ago

Don't know what went wrong, as the merged PR #526 stated closes #489 - but it did not close this issue when merged :shrug:

Can you close it @FlorianK13 ?