Hotfix 533 xml download yesterday misses gen url

OpenEnergyPlatform / open-MaStR

A collaborative software to download the energy database Marktstammdatenregister (MaStR)

https://open-mastr.readthedocs.io/en/latest/

GNU Affero General Public License v3.0

83 stars 17 forks source link

Hotfix 533 xml download yesterday misses gen url #534

Closed wok77 closed 2 months ago

wok77 commented 2 months ago

If accpeted, this commit will close issue #533 by adding the missing call to gen_url in open_mastr/xml_download/utils_download_bulk.py

Workflow checklist

Automation

Close #533

PR-Assignee

[ ] 🐙 Follow the workflow in CONTRIBUTING.md
[ ] 📝 Update the CHANGELOG.md
[ ] 📙 Update the documentation

Reviewer

[x] 🐙 Follow the Reviewer Guidelines
[x] 🐙 Provided feedback and show sufficient appreciation for the work done

FlorianK13 commented 2 months ago

Tests are failing as usual for PRs from outside, as the github secret API credentials are not exposed to PRs from outside. Hence we would need to merge without tests and see the test results before we do the next release.

FlorianK13 commented 2 months ago

I've checked the PR, added a few small changes and approved it. Big thanks to @wok77 for pointing this out!