OpenEnergyPlatform / open-MaStR

A collaborative software to download the energy database Marktstammdatenregister (MaStR)
https://open-mastr.readthedocs.io/en/latest/
GNU Affero General Public License v3.0
88 stars 19 forks source link

Feature 562 export storage units #565

Closed nesnoj closed 2 months ago

nesnoj commented 2 months ago

Summary of the discussion

Allows CSV export of table storage_units

Updated

Workflow checklist

Automation

Closes #562

PR-Assignee

Reviewer

nesnoj commented 2 months ago

Oh, discovered a bug in my implementation, will check..

nesnoj commented 2 months ago

Ok, good to go now

FlorianK13 commented 2 months ago

There is the problem of tests not running. This happens when:

I just checked but I could find no way to run the tests manually on this PR. @nesnoj do you know this problem and a solution? The only solution that I know is to add a small change and push it to the feature branch, which will trigger the tests.

nesnoj commented 2 months ago

Ok, did some minor "fix" to trigger ;)

Thanks for the explanation @FlorianK13 ! This is quite weird, maybe the trigger ready_for_review could do the trick..

BTW, the if statement in the test if: ${{ !github.event.pull_request.draft }} is not required to my mind as tests should not be triggered in draft PRs by default.