Closed nesnoj closed 2 months ago
Oh, discovered a bug in my implementation, will check..
Ok, good to go now
There is the problem of tests not running. This happens when:
I just checked but I could find no way to run the tests manually on this PR. @nesnoj do you know this problem and a solution? The only solution that I know is to add a small change and push it to the feature branch, which will trigger the tests.
Ok, did some minor "fix" to trigger ;)
Thanks for the explanation @FlorianK13 !
This is quite weird, maybe the trigger ready_for_review
could do the trick..
BTW, the if statement in the test if: ${{ !github.event.pull_request.draft }}
is not required to my mind as tests should not be triggered in draft PRs by default.
Summary of the discussion
Allows CSV export of table
storage_units
db.to_csv()
anddb.to_csv("storage_units")
now export tobnetza_mastr_storage_units_raw.csv
.db.download("bulk", data="storage")
does not includestorage_units
/anlagenstromspeicher
anymore as I had to split "storage" inBULK_INCLUDE_TABLES_MAP
to allow for CSV export. Instead, if a user wants only the storage units to be written to the DB, they need to be written separately viadb.download("bulk", data="storage_units")
. I assume most users write all data to the DB anyways (db.download("bulk")
) which works properly.Updated
storage_units
#562Workflow checklist
Automation
Closes #562
PR-Assignee
Reviewer