search

OpenEnergyTools / oscd-publisher

Apache License 2.0
1 stars 2 forks source link

Delete GSE from communication section when GSEControl is deleted #4

Closed jarradraumati closed 10 months ago

jarradraumati commented 11 months ago

When I delete a GSEControl from an IED in the Publisher editor, it does not remove the GSE from the Communication section.

The workaround is to use the Communication Editor to delete the GSE manually.

It would be nice if the publisher editor automatically removed the GSE from the communications section, since having a GSE without a valid GSEControl isn't valid.

Here is an SCD file where IED XAT_T1_P2 has a Test_1 GSE, but no GSEControl.

XAT (12) (1).zip

JakobVogelsang commented 10 months ago

Thanks for spoting! I will have a look.

JakobVogelsang commented 10 months ago

@jarradraumati This should be covered by the [https://github.com/openenergytools/scl-lib]. I just had a look and there are tests for this used-case. There is probably a bug. I will open an issue there as well and you can follow the development. Just out of curiosity: which GSEControl did you delete?

jarradraumati commented 10 months ago

@JakobVogelsang I deleted GSEControl Test_1 from IED XAT_T1_P2

JakobVogelsang commented 10 months ago

Should be fixed in the new oscd-publisher version and the new scl-editor version. Thx again for spotting.