search

OpenEnergyTools / scl-lib

5 stars 4 forks source link

Update confRev on dataset removal from control block #103

Closed danyill closed 4 months ago

danyill commented 4 months ago

What we do is on removal of a dataset we sent confRev to 0.

https://github.com/OpenEnergyTools/scl-lib/blob/bd020d3a5534ec9da2915c5f1c7ff5518214b9d6/tDataSet/removeDataSet.ts#L14-L34

But I think it should be incremented instead, "inclusive removal of this" in the standard:

image

(Background https://github.com/OpenEnergyTools/oscd-publisher/issues/17)

JakobVogelsang commented 4 months ago

Yes so true...I will fix this!

github-actions[bot] commented 1 month ago

:tada: This issue has been resolved in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: