search

OpenEnergyTools / scl-lib

5 stars 4 forks source link

Ensure serviceType handled correctly on unsubscribe, closes #27 #29

Closed danyill closed 1 year ago

danyill commented 1 year ago

I have adapted L67:

I have done this:

expect(update.attributes).to.not.have.own.property("serviceType");

To me, checking that it is undefined also seems fine, I just like that this is more explicit. Perhaps I have not understood your comment.

Please fixup the two and when added reviews to one commit. I would love to work with rebase on mergin to main and having additional commits would read strage.

Sure, sounds fun.

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: