OpenEnergyTools / scl-lib

5 stars 4 forks source link

Subscribe #33

Closed JakobVogelsang closed 1 year ago

JakobVogelsang commented 1 year ago

Closes #9

JakobVogelsang commented 1 year ago

Regarding the subscription to FCD: I myself am not fully sure. This is how I understand it:

You can subscribe an FCD in two ways - with later binding only with missing pDO or pDO present but missing pDA:

  1. Have ExtRef without daName (it is up to the vendor tool to pick the data from the DO with a specific fc). This is the way this function is doing it right now.
  2. Subscribe all or some of the data attributes with the defined fc individually. Here we would need to extend.

Describing FCD types to later binding type ExtRef is a tricky business, though. So far I understood it is up to the ICT tool what of the data attributes is accepted in the end. For documentation purpose, it therefore is necessary to have a roundtrip over the ICT tool. Exactly for this purpose, I have chosen the variant 1. With that, at least you make sure all data attributes are available to the ICT tool at the end.

For variant 2 we would need to have an extra key in the source like so:

source: {
 fcda: Element;
 dataAttributes?: string[];
 controlBlock?: Element;
}

If you want to know how variant 2 would look like, take a look at Annex H Used Case 1.

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: