search

OpenEnergyTools / scl-lib

5 stars 4 forks source link

fix(tIED): Refactor insertIED to avoid duplicate ConnectedAPs #72

Closed danyill closed 10 months ago

danyill commented 11 months ago

Closes #71

Also, renames the importIED folder to insertIED, hope this is acceptable.

My formatter seems to lint differently but I am not sure why, sorry about this - I did use npm run format.

I'd be grateful for a review and happy to make improvements! No hurry, next year some time is fine :wink:

JakobVogelsang commented 11 months ago

Thank you very much. This is a great contribution. I shall have a look.

To resolve the issue with the formatting, you need to npm install. Chris has added the prettier as a dependency in the packege.json.

danyill commented 11 months ago

To resolve the issue with the formatting, you need to npm install. Chris has added the prettier as a dependency in the packege.json.

Done, thanks for the tip.

I shall have a look.

As always, gracias.

danyill commented 10 months ago

I've rebased on main and run npm run format which has also modified a few other files by default:

        modified:   package-lock.json
        modified:   tExtRef/doesFcdaMeetExtRefRestrictions.spec.ts
        modified:   tExtRef/doesFcdaMeetExtRefRestrictions.ts
        modified:   tExtRef/subscribe.ts
        modified:   tIED/insertIED.ts

So I've reverted all the ones except related to this PR.

github-actions[bot] commented 4 weeks ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: