search

OpenEnergyTools / scl-lib

5 stars 4 forks source link

tGenerator: lnInst generation capped at 99 #74

Open danyill opened 8 months ago

danyill commented 8 months ago

I notice that lnInstGenerator only goes up to 99 but it seems to me that this can be much more.

I think in general we're using other functionality to check for LGOS and LSVS instances, but arguably if the user passes these it could be read from the Services section for LGOS and LSVS supervisions nodes.

https://github.com/OpenEnergyTools/scl-lib/blob/5449b179a2a4ed7ff18f67f2e28064de223663e4/generator/lnInstGenerator.ts#L10-L14

<xs:simpleType name="tLNInst">
  <xs:restriction base="xs:normalizedString">
  <xs:pattern value="[0-9]{1,12}"/>
  </xs:restriction>
</xs:simpleType>

This is not terribly important but I thought I'd mention it.

JakobVogelsang commented 5 months ago

Thank you. Very much right. From what I remember that prefix and ln inst together are limited to 13 chars. That is why I went for two char for the ln inst. But we should rethink that.