search

OpenEtherCATsociety / SOES

Simple Open Source EtherCAT Slave
Other
588 stars 251 forks source link

correct eeprom command #105

Closed Joanle closed 2 years ago

Joanle commented 2 years ago

Change eeprom reload command to the correct value according documentation.

nakarlsson commented 2 years ago

@hefloryd , seems to be something wrong with the automatic builds? Is it the ubuntu 16.xx issue here aswell?

Joanle commented 2 years ago

I am not sure. Is there more information of what failed specifically?

Reason for my change in the first place is that I came across an issue with eeprom emulation when implementing it on a stm32 microcontroller and microchip’s LAN9253 IC. The eeprom command for reload was being received by the host mcu as 0x4 but it was not being acknowledged because the macro definition used to check for it has reload command defined as 0x3. So I checked the documentation to verify the command’s value and it is indeed 0x4 not 0x3. That was my only change.

On Oct 24, 2021 at 9:25 AM, <nakarlsson @.***)> wrote:

@hefloryd (https://github.com/hefloryd) , seems to be something wrong with the automatic builds? Is it the ubuntu 16.xx issue here aswell?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (https://github.com/OpenEtherCATsociety/SOES/pull/105#issuecomment-950334275), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AOSXMA4ZEWBQW3VAAX5EC3TUIQJLZANCNFSM5GDGUZAQ). Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub).

nakarlsson commented 2 years ago

It’s no problem with your fix , it is ok. Something wrong with the automtic builds. But it is good to let the builds pass before mergeing, so let us fix it and we’ll merge.

Joanle commented 2 years ago

Oh okay. I understand. Thank you.

On Oct 24, 2021 at 12:20 PM (x-apple-data-detectors://0), <nakarlsson @.***)> wrote:

It’s no problem with your fix , it is ok. Something wrong with the automtic builds. But it is good to let the builds pass before mergeing, so let us fix it and we’ll merge.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (https://github.com/OpenEtherCATsociety/SOES/pull/105#issuecomment-950361368), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AOSXMA6MUCHJJSDLQRCP7DTUIQ54HANCNFSM5GDGUZAQ). Triage notifications on the go with GitHub Mobile for iOS (https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or Android (https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub).

hefloryd commented 2 years ago

Build should be fixed by #106

nakarlsson commented 2 years ago

@Joanle , can you rebase this on #106?