OpenEtherCATsociety / SOES

Simple Open Source EtherCAT Slave
Other
578 stars 249 forks source link

ecat control latch input selection and ecat reset request #56

Closed elsp1991 closed 5 years ago

elsp1991 commented 5 years ago

Hello guys, I just found out that the latch inputs selected with the defines in the esc_hw.c are not actually being applied to the real hardware. Also found that there is a way to remorely reset a Slave from the master side by enabling the ECATRSTEN bit in ecat port control. Let me know your thoughts for the proposed fix.

nakarlsson commented 5 years ago

Thanks for feedback, the XMC port was provided by a third party. Quick questions, have you verified the changes on HW and are they aligned with Infineon ref EtherCAT samples?

Basically, does it compile/run on XMC_Peripheral_Library_v2.1.6p1.zip given in SOES/applications/xmc4300_slavedemo/XMC_Peripheral_Library/

elsp1991 commented 5 years ago

I have tested it with XMC library v2.6.16 and compiles and runs with no problem. But did not test the actual functionality of latch inputs yet, cause I am using it in free-run mode. I can provide you feedback in the near future regarding the latch-in as it is in my road map to implement it

nakarlsson commented 5 years ago

Ok, it think free-run is OK . The change make sense and is pretty straight forward, I'll try to check if it compiles on XMC_Peripheral_Library_v2.1.6p1.zip or "update" to a newer version

nakarlsson commented 5 years ago

I'll merge when you fix the comments, I've tested that it builds with mentioned XMC peripheral lib

elsp1991 commented 5 years ago

Done