search

OpenEtherCATsociety / SOES

Simple Open Source EtherCAT Slave
Other
578 stars 249 forks source link

Setting for `value` size in `_objd` #59

Closed mheden closed 5 years ago

mheden commented 5 years ago

I've noticed that the the size of value in _objd has been changed from uint32_t to uint64_t (https://github.com/OpenEtherCATsociety/SOES/blob/master/soes/esc_coe.h#L24).

I find that I seldom (i.e. never) use 64 bit values so this is rather wasteful for object dictionaries with many entries. I don't know what the rationale behind the change was but could we maybe consider adding a #ifdef OD_LARGE_VALUE setting or similar that toggle between 4 and 8 byte values?

nakarlsson commented 5 years ago

can you provide a PR as proof of concept?