OpenEugene / little-help-book-web

Human service resource guide powered by White Bird Clinic
MIT License
6 stars 4 forks source link

Bug: Refactor headers to fix overlapping elements #123

Closed dwolfe closed 3 years ago

dwolfe commented 3 years ago

This PR standardizes header markup and refactors the related styles to fix the overlapping elements shown here:

Screen Shot 2020-10-15 at 12 46 19 PM

"Refactoring" in this case means moving the header styles into one continuous block in styles.css for the CSS, and modifying the markup and styles so that flexbox can handle the layout, which makes explicit margins/padding/positioning unnecessary. All pages should have the fixes.

Note: I only did what was necessary to fix the overlapping issue, and I made guesses about what content is intended for the header on each page. After @ArthurSmid checks that the content of each header is correct, I'll make any required changes there.

Also, on pages that have the three select menus (ex. category.html), the header doesn't collapse at browser widths between the 1056px breakpoint, and about 1325px. We'll need a solution for that - maybe moving the select menus out of the header, to the top of the page body? Let's discuss and I'll make the necessary changes pre-merge.