Closed xipxape closed 3 years ago
I still need to write tests and we should probably talk about how keywords are actually being used.
I haven't read through the changes carefully, but I wanted to write something here so we don't miss talking about it. Should we limit the number of keywords a person sends to the search? They could purposely overload our database by sending in a novel into the search box, couldn't they?
I haven't read through the changes carefully, but I wanted to write something here so we don't miss talking about it. Should we limit the number of keywords a person sends to the search? They could purposely overload our database by sending in a novel into the search box, couldn't they?
@codegold79 Sure. I don't know how big of an issue that could be, but I know Google, for example, only allows searching by the first 30-something words. I'm not sure, however, where we would put that logic. We could put a filter here, but I feel like that belongs somewhere else in the code. I'm not sure, I'm new to this base.
Also, we may want to limit the number of results a person gets back. I know @coatsd was working on that in another branch, but I'm not sure when/if those changes will be live.
Closes #141