search

OpenF2 / F2

Redefining web integration for the financial services community
Apache License 2.0
130 stars 62 forks source link

Container config updates (v1.3.3) #155

Closed montlebalm closed 10 years ago

montlebalm commented 10 years ago

This should fix the issue #154.

I apologize for the numerous whitespace changes. I didn't realize they were made until I created this PR. The relevant changes take place in container.js between lines 219-457.

markhealey commented 10 years ago

I have to update the version of Bootstrap used for the F2 docs because of this bug in < 2.3.

markhealey commented 10 years ago

Actually per my changes in b010bc98bb7d2ea8bf14d68f10210de486a19e4d and this comment I was able to shortcut upgrading the full docs src LESS files. That shortcut, in this case, is a good thing because we have a full F2 website redesign in progress.

markhealey commented 10 years ago

Thanks @zackferraro for that feedback. Currently the AppManifest.scripts must be an array of strings (URLs) but I like the idea of breaking down the mechanism applied to different manifests.

montlebalm commented 10 years ago

@markhealey and I discussed the issue of inline scripts and decided it would be best to separate them from the script files. The new branch contains an additional override called "loadInlineScripts". This should achieve two things:

  1. Containers no longer need to to manually execute the inline scripts just because they want to use a custom script loader.
  2. Containers will be less likely to deviate from the prescribed execution order (scripts => inline scripts).