search

OpenF2 / F2

Redefining web integration for the financial services community
Apache License 2.0
129 stars 62 forks source link

Depreciate `F2.isNativeDOMNode` #215

Closed montlebalm closed 3 years ago

montlebalm commented 9 years ago

As an F2 developer, I want to depreciate F2.isNativeDOMNode because I want F2 to contain only methods relevant to consumers.

Similar to #214, F2.isNativeDOMNode feels like a helper function that got added to the main API. I don't think it supports F2's goal of being a web integration library.

markhealey commented 9 years ago

cc @Ali-Khatami

Isn't this function core to AppHandlers? If it's required, maybe it should be private?

qrider commented 8 years ago

I am inclined with @markhealey on this. Let's make this private. It is a helper function and is pervasive throughout the code. One thing that it does well is enable us to notify the consumer if an invalid node is passed.

Locations this function is used: