Closed montlebalm closed 9 years ago
Does this include a script for deprecated backwards compat?
Does IE8 support indexOf
?
Doesn't look like it.
Here's a compatibility table too: http://kangax.github.io/compat-table/es5/#Array.prototype.indexOf
I'm not sure why I thought it was supported in IE8. I checked MDN, but it must have just been too late at night. I will pull that from the PR.
I also haven't created the transition script yet. I thought we'd make a new official repo named "F2-transition-1.5".
— Sent from Mailbox
On Tue, Dec 23, 2014 at 11:21 AM, Brian Baker notifications@github.com wrote:
Here's a compatibility table too: http://kangax.github.io/compat-table/es5/#Array.prototype.indexOf
Reply to this email directly or view it on GitHub: https://github.com/OpenF2/F2/pull/217#issuecomment-67968448
:hand: See note on #213 before this is merged.
I added the removed methods back and added @depreciated
indicators to the F2.log
, F2.parse
, and F2.stringify
methods. As discussed, IE8 does not have native support for Array.indexOf
, so we'll need to keep it around until we move to IE9 as our lowest supported browser.
@markhealey @brianbaker merge?
:+1:
Addresses #213.
This PR removes a few methods that were made redundant by functionality built-in to supported browsers. Please double check the changes -- especially to the doc sources -- and let me know if it looks good to merge.
Changes:
F2.parse
F2.stringify
F2.inArray
FYI, the "Removing" commits below should name the removed method, but it was stripped for some reason.