OpenF2 / F2

Redefining web integration for the financial services community
Apache License 2.0
129 stars 62 forks source link

Consistent source code styling #221

Closed montlebalm closed 7 years ago

montlebalm commented 9 years ago

Fixes #218.

The purpose of this PR is to format the codebase with a single style, so that it appears written with "one voice". In addition, it expands the linting rules to include more best practices.

There are several "relaxers" in the linting rules that can be removed once we move to a modular system that includes calling out explicit dependencies.

Changes:

montlebalm commented 9 years ago

@brianbaker @markhealey can you take a look at this when you get a chance? It took about 12 hours to complete, so it might take a little bit to review.

Are there any rules to want to remove from linting? Any you want to add?

There's a refactor of the CDS example app included in this PR. I probably should have left it out of this branch, but I think they need a touch up and it seemed to fit with the formatting theme.

brianbaker commented 9 years ago

Minor thing, but might be a good time to alphabetize the tasks in the Gruntfile.js. It is almost there but I think over time some of the tasks got out of order.