2.0.0 wip - Githubissues

OpenF2 / F2

Redefining web integration for the financial services community

Apache License 2.0

130 stars 62 forks source link

2.0.0 wip #305

Closed sjogendras closed 3 years ago

sjogendras commented 3 years ago

Replaced jQuery.Ajax with Fetch API
- Fetch API does not support the JSONP calls so making json calls using fetch api and JSONP calls using fetch-jsonp (https://www.npmjs.com/package/fetch-jsonp)
Removed jquery.noconflict from noconflict.js file

brianbaker commented 3 years ago

@sjogendras can you update ThirdPartyMaterial.md to include any applicable license for fetch-jsonp?

sjogendras commented 3 years ago

Thanks @brianbaker ! Looks like there is no license file for fetch-jsonp yet. Please suggest the next step. https://github.com/camsong/fetch-jsonp https://www.npmjs.com/package/fetch-jsonp

brianbaker commented 3 years ago

@sjogendras looks like it uses the MIT license: https://github.com/camsong/fetch-jsonp/blob/master/package.json#L34

so that we have everything covered, I would follow the template provided here: https://choosealicense.com/licenses/mit/ and substitute in values in that template for [year] and [fullname] so that we can have it documented.

sjogendras commented 3 years ago

Thanks for the guidance @brianbaker ! I have added the MIT license for fetch-jsonp. Please review.

brianbaker commented 3 years ago

@sjogendras @SandeepJamwal369 do you guys have more commits to add to this PR or are you ready for it to have final review/merge?

sjogendras commented 3 years ago

Hi, @brianbaker now we have done with our changes. Please review.

Thanks, Jogendra