OpenFAST / openfast

Main repository for the NREL-supported OpenFAST whole-turbine and FAST.Farm wind farm simulation codes.
http://openfast.readthedocs.io
Apache License 2.0
687 stars 457 forks source link

Map++: log_initialization_information function is always calling write_summary_file() #2396

Closed sanguinariojoe closed 1 month ago

sanguinariojoe commented 2 months ago

Bug description Look here. If a summary file is specified then write_summary_file() is called twice. Otherwise just once.

I am pretty sure line 2684 should be dropped

OpenFAST Version OpenFAST dev branch, commit e204587c4aa9e81f0d47a92c13ab9c7d7cc7aaf5

System Information (please complete the following information):

bjonkman commented 2 months ago

I agree. It looks like the additional line was added in commit c6bc9d18 (in April 2016), which was a merge of a couple of branches in svn.

andrew-platt commented 1 month ago

Corrected with #2405. Thanks @sanguinariojoe for reporting this!