OpenFLUID / openfluid

OpenFLUID framework and applications
https://www.openfluid-project.org/
Other
28 stars 15 forks source link

Duplicate generator can be added in Builder #929

Open Arthoni opened 4 years ago

Arthoni commented 4 years ago

Since generator identity is based on variableName.classUnit, two generators with identical parameters will have shared setting. Forbid identical generator creation in Builder generator creation dialog ?

Arthoni commented 3 years ago

Reproduced bug:

Arthoni commented 3 years ago

Fundamental principle: a variable for a unit class can be produced by only one ware therefore two generators with same unit class and variable names should not be accepted.

Case correctly handled at simulation level in Builder and CLI:

* Checking consistency... [Error]

OpenFLUID ERROR: var10 variable on unitsA produced by var10.unitsA.genscalar cannot be created 
because it is already created