search

OpenFTC / OpenCV-Repackaged

10 stars 8 forks source link

Why are shared objects not packaged with the AAR? #5

Closed pietroglyph closed 4 years ago

pietroglyph commented 4 years ago

Right now you instruct users to copy libOpenCvNative.so to a specific directory on the device and then you load the shared object from that specific path via System.load. This adds an extra step to the setup process, and I was wondering if there was any reason you don't place the shared object under src/main/jniLibs/{ABI TRIPLE}/ where it will be automatically included in the AAR?

If there's no reason that this isn't being done then I'll go ahead and make a PR that packages the shared objects in this manner.

Windwoes commented 4 years ago

Actually, extra work was done specifically in order to be able to load it from external storage instead of packaging it with the artifact in order to prevent the RC APK from being bloated another 10MB, which can have a significant effect on wireless ADB deploy times.