OpenFTC / OpenCV-Repackaged

11 stars 8 forks source link

Requesting Update to OpenCV 4.5.3 #7

Closed IronReignRobotics closed 3 years ago

Windwoes commented 3 years ago

Any specific thing you're looking to gain from a newer version? Not all improvements apply to the Android build.

IronReignRobotics commented 3 years ago

We are going for obstacle detection using intel realsense cameras. depth frames can be processed to remove ground point so that obstacles like other robots can be detected and avoided. Something similar to this: http://www.sayef.tech/post/ground-detection-and-removal-from-point-clouds/ OpenCV 4.5 has an update to RANSAC that might perform well enough on control hub hardware: https://opencv.org/evaluating-opencvs-new-ransacs/

Windwoes commented 3 years ago

Hmm, I am looking into this, but when I locally test 4.5.3, I am getting a dynamic linker error at runtime:

dlopen failed: library "libc++_shared.so" not found
Windwoes commented 3 years ago

Okay, managed to get past that by using a dummy target to have gradle pull that in.

If you add this maven staging repo:

repositories {
    maven { url 'https://oss.sonatype.org/content/repositories/orgopenftc-1008/'}
}

You should be able to give my test build for 4.5.3 a try by doing the following:

dependencies {
    implementation ('org.openftc:easyopencv:1.4.4') {
        exclude group: "org.openftc", module: "opencv-repackaged"
    }
    implementation 'org.openftc:opencv-repackaged:5.4.3-B'
}

Edit: whoops, I typoed the version number when I uploaded to the staging repo, (5.4.3 instead of 4.5.3). Doesn't really affect anything, I'll fix that before releasing.

Windwoes commented 3 years ago

Here's the updated native library.

libOpenCvAndroid543.zip

IronReignRobotics commented 3 years ago

Sweet - It Works!!!

Do you want me to close it now or once you release it?

Windwoes commented 3 years ago

Once I release it. Does the new version provide the improvements you were hoping for?

IronReignRobotics commented 3 years ago

It does. Not that we've been able to implement yet, but it has the ransac/usac improvements introduced in 4.5.0. Thank you!

On Sun, Sep 5, 2021, 7:25 AM Windwoes @.***> wrote:

Once I release it. Does the new version provide the improvements you were hoping for?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OpenFTC/OpenCV-Repackaged/issues/7#issuecomment-913145272, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRFRSMPMSS3XR36PVZA3CDUANOUBANCNFSM5C7HQV3Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Windwoes commented 3 years ago

EOCV v1.5.0 is now live and uses OpenCV v4.5.3