OpenFabrics / sunfish_library_reference

The core Sunfish implementation
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Issue 11 #15

Closed mgazz closed 4 months ago

mgazz commented 5 months ago

With these changes the patch method takes as input only the changes that we want to apply to the target object. I also updated the test to fit the new mechanism.

See #11 for a more detailed description of the problem.

christian-pinto commented 5 months ago

@mgazz this needs to be rebased on the current master. Also, all commits must be signed. See the DCO check failing.

mgazz commented 5 months ago

@christian-pinto thank you for the review. I rebased the branch and added verified commits. I'll be available in case on any question.

christian-pinto commented 4 months ago

@mjaguil could you please have a look at this PR?

mgazz commented 4 months ago

@dledford thank you for the feedback. I will update the spacing to make it more consistent.