Issue 12 - Githubissues

OpenFabrics / sunfish_library_reference

The core Sunfish implementation

BSD 3-Clause "New" or "Revised" License

2 stars 4 forks source link

Issue 12 #16

Closed mgazz closed 4 months ago

mgazz commented 5 months ago

This PR is a follow up of #15

It updates the handlers processing the AggregationSourceDiscovered and ResourceCreated events. At the reception of the AggregationSourceDiscovered event the handler adds a UUID as Context to the Subscription. The Agent will have to add such Context to the following Events issued to the Sunfish server.
It adds a Makefile simplifying the steps to build the whl

christian-pinto commented 5 months ago

@mgazz this needs to be rebased on the current master. Also, all commits must be signed. See the DCO check failing.

mgazz commented 5 months ago

@christian-pinto thank you for the review. I rebased the branch and added verified commits. I'll be available in case on any question.

mgazz commented 4 months ago

@dledford thank you for the feedback. I agree with your request for changes. I will update as requested.

Your review bring up something that we have yet to discuss: styling. We have yet to tackle this problem, we can adopt a linter that will help us styling the code automatically (example: pylint,flake8,etc..). (We can discuss this in another issue).

mgazz commented 4 months ago

I believe all styling issues are resolved. Some have been resolved in #15. I would first merge that pull-request if all issues are resolved. Once that is done, I will rebase this branch.