search

OpenFactorioServerManager / factorio-server-manager

A tool to help manage Factorio multiplayer servers including mods and save games.
MIT License
544 stars 132 forks source link

[save].tmp.zip bad zip file (Win10) #225

Closed nielrio closed 3 years ago

nielrio commented 3 years ago

Every time I 'Save & Stop Server' (on windows 10) it starts saving, This happens:

2021/01/17 21:49:00 Sent SIGINT to Factorio process. Factorio shutting down... 2021/01/17 21:49:00 Factorio Server: 32.432 Received SIGINT, shutting down 2021/01/17 21:49:00 Factorio Server: 32.448 Quitting: signal. 2021/01/17 21:49:00 Factorio Server: 32.448 Info MainLoop.cpp:417: Saving map as C:\Users\nielrio\Desktop\Servers\Factorio\factorio-server-manager\saves\Save_file.zip 2021/01/17 21:49:01 Factorio Server: 32.972 Info MainLoop.cpp:428: Saving progress: 0.003539% 2021/01/17 21:49:02 Factorio Server: 33.972 Info MainLoop.cpp:428: Saving progress: 97.111908% 2021/01/17 21:49:02 Factorio Server: 33.998 Info MainLoop.cpp:428: Saving progress: 100.000000% 2021/01/17 21:49:02 new state, will also send to correct room 2021/01/17 21:49:02 Factorio server stopped 2021/01/17 21:49:02 Factorio process exited with error: exit status 1 2021/01/17 21:49:02 Error starting Factorio server: exit status 1

Looks like when the factorio server is saving, it creates a .tmp.zip file, but it doesen't get the time to copy to .zip

Do more people have this issue?

nielrio commented 3 years ago

When I do --start-server-load-latest the next time, the server quits with 'Bad zip file'

Explorer.exe also says 'Bad zip file'

knoxfighter commented 3 years ago

Cannot confirm on ubuntu 18.04. .tmp.zip file will be renamed after write is done. I will test it on Windows later. This could also just be a problem with factorio itself.

knoxfighter commented 3 years ago

Cannot confirm on Windows 7. Please send me the files (the working save and the .tmp.zip file) so i can have a deeper look, what's goind on. @nielrio

nielrio commented 3 years ago

Island revived.zip Island revived.tmp.zip

Btw, I am not able to recreate the .tmp.zip anymore.

so I guess it's working fine now.

Factorio still exits with error status 1 tho, or is that normal?

knoxfighter commented 3 years ago

I got it myself once now. It seems like the .tmp.zip file is just a file, that remains by accident. The normal .zip mp seems to be the successfully saved map, that just can be used to start. I think we should just hide .tmp.zip files.

Also it seems like the exit status 1 is normal.

nielrio commented 3 years ago

Ok, then I will close this with this comment, and the .tmp.zip hiding is a good one.

Tnx for support!