Trying to install mods fails during a request with "?page_size=max"

OpenFactorioServerManager / factorio-server-manager

A tool to help manage Factorio multiplayer servers including mods and save games.

MIT License

544 stars 132 forks source link

Closed EinPinsel closed 3 years ago

EinPinsel commented 3 years ago

Thanks for this awesome little tool. I like it a lot :) Currently I'm trying to install mods into a brand new server and currently it fails because requesting all the mods ends up in an error. Currently there are only about 320 pages of mods, so I could hotfix it, but I'm not sure if that would worth a PR https://github.com/OpenFactorioServerManager/factorio-server-manager/blob/bcbf3ffd3d15dd6600f25ae6681d1bf6f55a9374/src/factorio/mod_portal.go#L33

mroote commented 3 years ago

Hi @EinPinsel,

Glad you like the manager! @knoxfighter just pushed a fix for this issue to develop yesterday.

EinPinsel commented 3 years ago

Ups. Now I did it myself as well 😅 I tried to help :D

mroote commented 3 years ago

haha thanks for the contribution! You can pull the develop docker container in the meantime to get the fixed version.

knoxfighter commented 3 years ago

Duplicate of #219