search

OpenFactorioServerManager / factorio-server-manager

A tool to help manage Factorio multiplayer servers including mods and save games.
MIT License
541 stars 130 forks source link

Rcon port config #275

Closed Mirdinus closed 3 years ago

Mirdinus commented 3 years ago

Rcon port taken from config file or generated random if not set

Mentioned in issue 240

mroote commented 3 years ago

Thanks for the contribution! I made one small comment. It might be nice to expose this option as a flag when starting the server-manager as well.

Mirdinus commented 3 years ago

No problem. I like that suggestion, but I think it should be done together with rcon_pass in some of the following PRs

mroote commented 3 years ago

No problem. I like that suggestion, but I think it should be done together with rcon_pass in some of the following PRs

True it would make sense to expose the password option as well.

knoxfighter commented 3 years ago

https://github.com/OpenFactorioServerManager/factorio-server-manager/blob/bdc79b9073ae3b9a437575f61d09f9fa69422f07/src/bootstrap/config.go#L43-L44

The password and the port are exposed in the json file (they are not automatically added in there)

mroote commented 3 years ago

Should we add this config option to the updateConfigFile function to add it? Or maybe add it to the sample config as an option.