search

OpenFactorioServerManager / factorio-server-manager

A tool to help manage Factorio multiplayer servers including mods and save games.
MIT License
541 stars 130 forks source link

Fixed custom chat log option #313

Closed Mattie112 closed 2 years ago

Mattie112 commented 2 years ago

It seems that I tested it with an old (cached?) docker image. It was working for me but I updated some stuff and it was no longer working. It seems that the server was started before the --console-log option as added to the arguments. Sorry for that!

Mattie112 commented 2 years ago

I can't image my change broke the build, it does not find Visual Studio. Not sure of the exact build process.

gyp ERR! find VS 
gyp ERR! configure error 
gyp ERR! stack Error: Could not find any Visual Studio installation to use
gyp ERR! stack     at VisualStudioFinder.fail (D:\a\factorio-server-manager\factorio-server-manager\node_modules\node-gyp\lib\find-visualstudio.js:121:47)
gyp ERR! stack     at findVisualStudio2013 (D:\a\factorio-server-manager\factorio-server-manager\node_modules\node-gyp\lib\find-visualstudio.js:74:16)
gyp ERR! stack     at VisualStudioFinder.findVisualStudio2013 (D:\a\factorio-server-manager\factorio-server-manager\node_modules\node-gyp\lib\find-visualstudio.js:351:14)
gyp ERR! stack     at findVisualStudio2015 (D:\a\factorio-server-manager\factorio-server-manager\node_modules\node-gyp\lib\find-visualstudio.js:70:14)
gyp ERR! stack     at regSearchKeys (D:\a\factorio-server-manager\factorio-server-manager\node_modules\node-gyp\lib\find-visualstudio.js:372:16)
gyp ERR! stack     at regGetValue (D:\a\factorio-server-manager\factorio-server-manager\node_modules\node-gyp\lib\util.js:54:7)
gyp ERR! stack     at D:\a\factorio-server-manager\factorio-server-manager\node_modules\node-gyp\lib\util.js:33:16
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:301:5)
gyp ERR! stack     at ChildProcess.emit (events.js:198:13)
gyp ERR! stack     at maybeClose (internal/child_process.js:982:16)
gyp ERR! System Windows_NT 10.0.20348
gyp ERR! command "C:\\hostedtoolcache\\windows\\node\\10.24.1\\x64\\node.exe" "D:\\a\\factorio-server-manager\\factorio-server-manager\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
Mattie112 commented 2 years ago

(in case anyone wants to test, develop + https://github.com/OpenFactorioServerManager/factorio-server-manager/pull/286 + this patch: docker pull mattie112/temp:factorio-server-manager)

mroote commented 2 years ago

Thanks for catching this @Mattie112!