OpenFactorioServerManager / factorio-server-manager

A tool to help manage Factorio multiplayer servers including mods and save games.
MIT License
541 stars 130 forks source link

Display Save times in user locale and timezone #314

Closed EphDoering closed 2 years ago

EphDoering commented 2 years ago

This changes the displayed date-time format on the save page from ISO UTC to the user's locale and timezone as defined by their web browser. This should fix/close issue #299.

EphDoering commented 2 years ago

Looks like it's trying to use version* 64 of node-sass which is no longer available prebuilt. So then it's trying to build it but is either missing the required configuration or toolchain to do so properly.

On my windows system it built without errors but it fetched node-sass version 83 rather than 64. I'm not super familiar with node module versioning or package locking so I'm not sure why mine built with 83 and the automated test tried to use 64. But in either case I don't think this is an issue with my change, and I do think this same issue is causing PR #313 to also fail even though that change only was affecting the go server.

mroote commented 2 years ago

Thanks @FrederickDoering!