search

OpenFactorioServerManager / factorio-server-manager

A tool to help manage Factorio multiplayer servers including mods and save games.
MIT License
541 stars 130 forks source link

update javascript dependencies #326

Closed jannaahs closed 8 months ago

jannaahs commented 2 years ago

This will update all the javascript dependencies.

I've updated tailwindcss to the latest version and moved from the deprecated node-sass to sass.

No errors or warnings when building the frontend.

knoxfighter commented 2 years ago

My plan is to update all dependencies to the latest MAJOR version. That will surely break things. So please update that as well.

jannaahs commented 2 years ago

My plan is to update all dependencies to the latest MAJOR version. That will surely break things. So please update that as well.

@knoxfighter Yeah, I wanted that as well. I tried to look into the MapGenerator again and noticed we could need an update of the dependencies. I'll probably need some time to figure out why the github action is failing, because I can build the frontend locally. I just ask for the code review so you know about it and don't start doing it as well :smile:

knoxfighter commented 2 years ago

Ah, i see, could have created is as DraftPR :) The npm failed previously for windows only, cause of the update to VS2022, but now that the ubuntu is failing, you have to look yourself.

jannaahs commented 2 years ago

It seems to be related to tailwindcss. I'll have a look at it tomorrow or so.

jannaahs commented 2 years ago

@knoxfighter you can now have a look at it.

louisza commented 1 year ago

@knoxfighter is this ready to be pushed to the develop branch?

knoxfighter commented 8 months ago

Writing it down now, since i currently have a look at it and will fix this the following weeks: The update of react-router from v5 to v6 changed the fundamentals completely, therefore i have to rewrite everything that does something with routes (which is most of it ...)

knoxfighter commented 8 months ago

Writing it down now, since i currently have a look at it and will fix this the following weeks: The update of react-router from v5 to v6 changed the fundamentals completely, therefore i have to rewrite everything that does something with routes (which is most of it ...)

Wasn't that bad, got a working UI again now :partying_face:

knoxfighter commented 8 months ago

If anybody wants to have another look, i would love the feedback. In either case, i will merge this PR on Tuesday.

Mattie112 commented 8 months ago

I can try it out but not before the weekend :) But we can always test in production ;)

knoxfighter commented 8 months ago

@Mattie112 I merge this PR now, i would love if you test the changes on the develop branch. You can either answer here, in a new issue, or on our discord, thank you :)

Mattie112 commented 8 months ago

Did not notice any issues 👍