OpenFactorioServerManager / factorio-server-manager

A tool to help manage Factorio multiplayer servers including mods and save games.
MIT License
541 stars 129 forks source link

feat: allow CLI tuning #364

Closed cdaringe closed 8 months ago

cdaringe commented 8 months ago

Problem

I wanted to tune my boot configuration, but could not

Solution

Support it!

knoxfighter commented 8 months ago

Hi, unfortunately I don't see any use case for this PR. All settings can already be changed either by docker itself or by using env varaibles or the conf.json.

So which issue do you address with this PR?

knoxfighter commented 8 months ago

how can i add more CLI flags to the factorio bin without this PR?

Good question, something to look into. This PR only adds additional parameters to the server-manager itself, which does nothing, since everything can be set through env variables as well.

Mattie112 commented 8 months ago

What settings are you looking for?

And perhaps an env / config var FACTORIO_FLAGS (string) so you can just supply --foo=bar --bar=foo --whatever

cdaringe commented 8 months ago

I was trying to pass —verbose to diagnose a mod that was failing to load. Since learned that Factorio fails silently when it is attempting to load mods and just skips them so it didn’t actually help me :-) I was just missing a dependency.

Mattie112 commented 8 months ago

Ah yes that is really annoying, created server added some nice (endgame) mods that also change science etc. Getting in the endgame hmmmm didn't I add a mod? And yes turned out I did not have some dependencies but it was a bit to late in the game to add it at that point.

Not sure if the --verbose is already included but indeed for commands like that a "custom" option would be nice. "often used" things should get a nice setting but some advanced settings yeah I don't mind.

cdaringe commented 8 months ago

same thing happened to me. "I think Krastorio is supposed to happen pretttttty soon here?"

launched rocket, was still waiting for krast 😄